Match plural "failures" in FAILING_RE check-status pattern - #20
Merged
Conversation
Co-authored-by: Julius Walton <ShiosOS@users.noreply.github.com>
ShiosOS
marked this pull request as ready for review
July 14, 2026 19:42
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The word-boundary
FAILING_REintroduced to replace the old substringfailmatcher coversfail,fails,failed,failing, andfailure, but not the pluralfailures. A check row whose accessible label reports failures only in that form (e.g. "ci 2 failures") is no longer classified as failing, so the conversation checks indicator can stay passing or unknown.Verified directly:
/\b(fail(?:ed|ing|ure|s)?|...)\b/i.test("2 failures")returnsfalse(the\bafterfailurefails against the trailings).Fix
Change the inflection group from
fail(?:ed|ing|ure|s)?tofail(?:ed|ing|ures?|s)?so bothfailureandfailuresmatch. Word-boundary behavior for check names likefailover-suiteis unchanged.Testing
Added a regression case (
"ci 2 failures"derives tofailing) to the inflected-status-phrase test. Full suite passes: 79 tests across 6 files.